Hot Reload: Do not add empty div when diagnostics are empty (1xx) #51837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Browser displays gray overlay when changes are applied that do not modify C# code (e.g. CSS only changes). The overlay obscures web page content.
We shouldn't display gray overlay when no errors are being reported.
Fixes #51825 and dotnet/aspnetcore#64051
Port of #51836
Customer Impact
Impacts Hot Reload for web apps: CSS editing and saving C#/Razor files without changing their content.
Regression?
Regressed by #51210
Risk
Verification
Packaging changes reviewed?